-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update device aygrochy_inline_wifi_air_vent product data #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Aygrochy Inline WIFI Air Vent Product Data according to Tuya Cloud Data
make-all
reviewed
Feb 6, 2025
custom_components/tuya_local/devices/aygrochy_inline_wifi_air_vent.yaml
Outdated
Show resolved
Hide resolved
custom_components/tuya_local/devices/aygrochy_inline_wifi_air_vent.yaml
Outdated
Show resolved
Hide resolved
Product id is available in two places (for some devices they are different ids):
|
Will look into it and update when I'm back home tomorrow. Thanks for the advice 🙏 |
@make-all I updated the JSON data. I'd appreciate it if you could have a look at it :) Query Device Details data for this Product: {
"result": {
"active_time": 1738670925,
"bind_space_id": "223878109",
"category": "xfj",
"create_time": 1716808011,
"custom_name": "",
"icon": "smart/icon/bay1634003854363NjDl/ddaaca01b1ed92a4128c511d4cdf1705.png",
"id": "bfa6958a160d31f713s2to",
"ip": "[REDACTED]",
"is_online": true,
"lat": "[REDACTED]",
"local_key": "[REDACTED]",
"lon": "[REDACTED]",
"model": "Ec-v1.0",
"name": "Fan Controller",
"product_id": "hqldzgqpsyr1pw8c",
"product_name": "Fan Controller",
"sub": false,
"time_zone": "+01:00",
"update_time": 1738670928,
"uuid": "d687884a65824125"
},
"success": true,
"t": 1739023704679,
"tid": "292b2999e62611efa76ab217c6c149bc"
} |
- follow HA naming convention - don't duplicate name as model_id. PR #2920
Thank you! 🎉 |
Just wanted to let you know that I added the device yesterday and it now works perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add my Aygrochy Inline Fan Controller to tuya-local and it was found, but it did not suggest the correct device type:
I tried to understand why this happens even though it was listed as a compatible device, and am currently thinking that this is because no product is configured in
aygrochy_inline_wifi_air_vent.yaml
'sproducts
data. Is that correct?If it helps, I updated the Aygrochy Inline WIFI Air Vent Product Data according to Tuya Cloud Data.
This is the data I got from the "Query Things Data Model". I'm not that deep into the tuya-local definitions of devices, so if anyone could check whether this still matches the configured model in
aygrochy_inline_wifi_air_vent.yaml
would be great.